fixes memory overflow with ldd4.3 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldd4.3 Assets.lif contains a large db.lif file which fails to be extracted because of a memory overflow error with python 2.7. this path make extraction by blocks of 16MB. if the block size is too large, it is divided by 2 till it fits the file size ... (could be improved though)
| f = open((outFolder + a[0]), "wb") | ||
| f.write(fileData[a[1]:a[1]+a[2]]) | ||
| b = a[1]; e = a[1]+a[2] ; step = 0x1000000 |
There was a problem hiding this comment.
I'd like to avoid setting multiple variables on one line.
|
The whole of LIF Extractor really could be improved, but I wouldn't mind merging some patches. I've just got a couple of notes above. |
|
Hi, |
|
If its ugly or not - it works 👍 |
|
How about finally patching this python file? Plus a documentation about the format would be pretty cool as I want to write a C# tool that does the same as your the python file (not requiring python, tho). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ldd4.3 Assets.lif contains a large db.lif file which fails to be
extracted because of a memory overflow error with python 2.7.
this patch make extraction by blocks of 16MB. if the block size is too
large, it is divided by 2 till it fits the file size ... (could be
improved though)